![]() User inputs are properly escaped (eg the correct param type is used and risky types such as raw are only used where necessary and safe to do so) and.Capabilities are checked where roles differ.Sesskey values are checked before all write actions where appropriate (some read actions as well).User login is checked where an identity is needed.The user community relies on Moodle being responsibly secure. Behat tests pass for related areas where changes have been made, especially when it involved UI changes.Unit tests pass for related areas where changes have been made.New unit tests have been added when there is a change in functionality and.The assignee has tested according to the instructions and verified that they are passing (This is the responsibility of the assignee, not the peer reviewer).They consider other perspectives of other users perhaps not considered by original developers e.g.Please ensure that the testing instructions: There are specific testing instructions that state how, as well as what, to test.Issues should not be sent for peer review without tests so that the peer reviewer can assess their quality and use them to consider the scope of the issue. It is the developer's responsibility to test code before integration. Testing instructions and automated tests The code uses SQL compatible with all the supported DB engines (check all selected fields appear in an 'ORDER BY' clause).There are minimal DB calls (no excessive use of the DB) and.If there is SQL code you can test quickly then do so. AMOS commands have been specified when moving or copying language strings.ĭB calls are the greatest performance bottleneck in Moodle.Language strings have not been removed or renamed, had their meaning changed or had their parameters changed in stable branches (permitted only in master) and.Language strings are used instead of hard-coded strings for text output.Help strings are named and formatted as described in Help strings.New language strings are named correctly (all lower case, no camel-case, underscores are permissible in some cases).To achieve appropriate internationalisation of Moodle, language strings must be managed correctly. For help with wordings for new features and improvements, add the ux_writing label to the issue. Any User Interface feature which is intended to be re-used by another part of the codeĮnsure that any new User Interface feature in Moodle 4.0 or later which matches the above criteria:.Any User Interface in a Moodle plugin which is intended to be re-used.Any User Interface in any Moodle core subsystem.Any User Interface in the Moodle core component.This applies to any feature introduced or updated from Moodle 4.0 onwards, which: Feedback any notices (E_STRICT, etc) seen into the MDL.Īny improvement or new feature that introduces UI features to Moodle core from Moodle 4.0 onwards must be documented within the Component library.All visual output has a RTL alternative included.The code doesn't use buffered output unless absolutely necessary.Existing classes/layouts provided by Bootstrap and/or the theme are used where possible.CSS has been added to the appropriate CSS files (base, specific area, sometimes canvas). ![]() No inline styles have been used in HTML output (everything has to be in CSS).Output renders are used to generate output strings, including HTML tags.Output needs to be controlled by renderers to achieve consistency and correct application of themes. However, take into account that for now, CiBot is not checking all file types (it happens, for instance, with the JavaScript files). So in this case it's recommended to review the execution results to validate that there aren't errors. Most of the previous items list are checked automatically by the CiBot (Automated code review). ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |